Repository navigation
Route prepared images through the attachment store - #46065
Merged
copyberry[bot] merged 1 commit intoSep 17, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## What changed Upload prepared images from messages and tool outputs through the session's `AttachmentStore` before recording history. Use the returned inline bytes or file reference, and fall back to the prepared inline image if upload fails. Keep history replay on `InlineAttachmentStore` so it does not upload recorded images, and preserve existing file references. Reuse image resizing directly for guardian review comparisons without uploading. ## Testing Add coverage for upload failure preserving resized inline images. Extend rollout coverage to verify that only new images are uploaded, uploaded bytes have the expected dimensions, and file references and resize notices survive replay. GitOrigin-RevId: e9966297c3579ef1e52376f0235fe3a7e3ec7ecc
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/e9966297c3579ef1e52376f0235fe3a7e3ec7ecc
branch
from
September 17, 2026 00:49
83e25a3 to
5e636ea
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/e9966297c3579ef1e52376f0235fe3a7e3ec7ecc
branch
September 17, 2026 00:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route prepared images through the attachment store
What changed
Upload prepared images from messages and tool outputs through the session's
AttachmentStorebefore recording history. Use the returned inline bytes or file reference, and fall back to the prepared inline image if upload fails.Keep history replay on
InlineAttachmentStoreso it does not upload recorded images, and preserve existing file references. Reuse image resizing directly for guardian review comparisons without uploading.Testing
Add coverage for upload failure preserving resized inline images. Extend rollout coverage to verify that only new images are uploaded, uploaded bytes have the expected dimensions, and file references and resize notices survive replay.